Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dependency of minio-java to 7.1.4 #1666

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Revert dependency of minio-java to 7.1.4 #1666

merged 2 commits into from
Feb 25, 2022

Conversation

vaulka
Copy link
Contributor

@vaulka vaulka commented Feb 20, 2022 •
edited by JohnNiang
Loading

Fix #1639

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

JohnNiang
JohnNiang requested changes Feb 20, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JarvisPongSky ,我们推荐回退 minio-java 依赖版本，毕竟我们还没有使用 minio-java 高版本特性的场景，这里贸然升级 okhttp3，可能会对 Spring Boot 依赖造成潜在的影响。等后续 Spring Boot 官方升级了 okhttp3 的版本后，我们再考虑升级 minio-java。

请参考：

@ruibaby
Copy link
Member

ruibaby commented Feb 23, 2022

@JarvisPongSky 你好，请问此 PR 还在继续吗？

@vaulka
Copy link
Contributor Author

vaulka commented Feb 23, 2022

结束了，就提交了一次。

@vaulka vaulka closed this Feb 23, 2022
@JohnNiang
Copy link
Member

结束了，就提交了一次。

Hi @JarvisPongSky , 没必要关闭这个 PR，你可以继续在当前分支上修改代码，然后执行代码推送操作。前提是你采纳我的观点：#1666 (review)

@JohnNiang JohnNiang reopened this Feb 23, 2022
@vaulka
Copy link
Contributor Author

vaulka commented Feb 23, 2022

啊哈，GitHub 多人协助不是很熟练，见谅，#1666 review 我觉得这个观点是对的，后续更改 minio 版本进行测试，再进行提交。

@JohnNiang
Copy link
Member

啊哈，GitHub 多人协助不是很熟练，见谅，#1666 review 我觉得这个观点是对的，后续更改 minio 版本进行测试，再进行提交。

期待进一步的 commit。

@ruibaby
Copy link
Member

ruibaby commented Feb 23, 2022

@JarvisPongSky 你好，我们需要 sign 一下 CLA，否则我们无法合并此 PR。

#1666 (comment)

@vaulka
Copy link
Contributor Author

vaulka commented Feb 25, 2022

@ruibaby 你好，我已签署 Google CIA，要怎么配合你 sign 呢？

@JohnNiang
Copy link
Member

Hi @JarvisPongSky ,

  1. 你可以点击这里：

    image

  2. 或者直接访问：https://cla-assistant.io/halo-dev/halo?pullRequest=1666

签署 License CLA。

@vaulka
Copy link
Contributor Author

vaulka commented Feb 25, 2022

@ruibaby 感谢您的引导，我已完成，现在我将测试 minio 低版本兼容的情况。

@vaulka
Copy link
Contributor Author

vaulka commented Feb 25, 2022

@ruibaby 您好，我查阅了 minio-java build.gradle ，获悉自从 7.1.4 version 以后，okhttp 依赖已升级至 4.8.1 version，所以将 minio version 回滚至 7.1.4 是一个安全的版本。

代码已提交，后续我将 close 该 PR 吗？还是等待您的指示？（我是小白，见谅😖）

@JohnNiang JohnNiang changed the title fix: minio 依赖中 okhttp 版本过低 Revert dependency of minio-java to 7.1.4 Feb 25, 2022
JohnNiang
JohnNiang approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnNiang JohnNiang merged commit 4bfc3c0 into halo-dev:master Feb 25, 2022
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. dependencies Pull requests that update a dependency file labels Feb 25, 2022
@guqing
Copy link
Member

guqing commented Feb 25, 2022

@ruibaby 您好，我查阅了 minio-java build.gradle ，获悉自从 7.1.4 version 以后，okhttp 依赖已升级至 4.8.1 version，所以将 minio version 回滚至 7.1.4 是一个安全的版本。

代码已提交，后续我将 close 该 PR 吗？还是等待您的指示？（我是小白，见谅😖）

等待我们测试后会处理 不需要你关闭👍

@vaulka
Copy link
Contributor Author

vaulka commented Feb 25, 2022

@guqing 好的，谢谢您 😃

@guqing
Copy link
Member

guqing commented Feb 25, 2022

该 PR 已经完成 感谢你的贡献👏👏 期待你的下次贡献🎉🎉

winar-jin pushed a commit to winar-jin/halo that referenced this pull request Mar 24, 2022
@vaulka @winar-jin
Revert dependency of minio-java to 7.1.4 (halo-dev#1666)
6060e82 
* fix: 降低 minio 版本，回滚至与 springboot 相对应的 okhttp 依赖版本
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minio 上传文件报错：Unsupported OkHttp library found. Must use okhttp >= 4.8.1
5 participants
@vaulka @CLAassistant @ruibaby @JohnNiang @guqing